enhance get_software_libdir to return lib or lib64 if only one of them contains library files
#4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are situations e.g. with recent Gentoo where all 64-bit libraries are under `lib64`, but `lib` is seperate and used for other files and directories (e.g. `lib/python`), and for 32-bit libraries. `get_software_libdir` would fail for such. To avoid this: if `only_one` is `True` (default), *and* no specific file (`fs`) is specified (also default), *and* `lib` and `lib64` both exist and are separate, and only one of them has libraries (shared or static), it returns that one directory.
boegel
changed the title
get_software_libdir: return dir if it's only 1 with libsget_software_libdir to return lib or lib64 if only one of them contains library files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are situations e.g. with recent Gentoo where all 64-bit libraries are under
lib64, butlibis seperate and used for other files and directories (e.g.lib/python), and for 32-bit libraries.get_software_libdirwould fail for such. To avoid this:if
only_oneisTrue(default), and no specific file (fs) is specified (also default), andlibandlib64both exist and are separate, and only one of them has libraries (shared or static), it returns that one directory.